Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Nats tests #5783

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Improve Nats tests #5783

merged 5 commits into from
Oct 19, 2024

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Sep 19, 2024 •
edited
Loading

Remove Polly and use WaitForText instead.

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 19, 2024
@build-analysis build-analysis bot mentioned this pull request Sep 20, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Sep 21, 2024
Open
3 tasks
@davidfowl
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

eerhardt
eerhardt approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the contribution.

@eerhardt
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt eerhardt enabled auto-merge (squash) October 18, 2024 02:59
@eerhardt
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt eerhardt merged commit 50a5e48 into dotnet:main Oct 19, 2024
9 checks passed
@Alirexaa Alirexaa deleted the nats-tests branch October 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alirexaa @davidfowl @eerhardt