Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the dcp resource on restart #5832

Closed
wants to merge 1 commit into from

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Sep 22, 2024

Description

This change makes the old dcp resource as hidden and makes a new resource. The UI can be a bit jarring as items are removed and then added.

Fixes #5803

PS: It's unclear if we want this change. I just wanted to understand the behavior and potential fix. Instead DCP could reset the log stream state when a new resource is created.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No

- This change makes the old dcp resource as hidden and makes a new resource. The UI can be a bit jarring as items are removed and then added.

Fixes #5803
@JamesNK
Copy link
Member

JamesNK commented Sep 22, 2024

I think this should be fixed in DCP. I logged an issue there.

The complete name is visible for replicas and changing the name will be visible in UI. Also, the telemetry uses the complete name so there will be two instances of the app in the telemetry pages.

@davidfowl davidfowl closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs break when restarting projects
2 participants