[release/8.0-preview1] Remove unnecessary subfolders from the session temp folder #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove extra subfolders from session temp folder path * Ensure the session folder is created with appropriate Unix permissions if it doesn't already exist * Check for Windows for proper CreateDirectory method * Remove extra using
karolz-ms
approved these changes
Nov 1, 2023
eerhardt
approved these changes
Nov 1, 2023
| @@ -263,7 +264,14 @@ private static Socket CreateLoggingSocket(string socketPath) | |||
| string? directoryName = Path.GetDirectoryName(socketPath); | |||
| if (!string.IsNullOrEmpty(directoryName)) | |||
| { | |||
| Directory.CreateDirectory(directoryName); | |||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | |||
There was a problem hiding this comment.
For a future PR, we can use OperatingSystem.IsWindows() here, which is the preferred way of doing this check.
|
@danmoseley or @davidfowl can I get an approval from either of you so this can be merged? |
danmoseley
approved these changes
Nov 1, 2023
|
This isn't as critical as the other PR, but it does reduce the chance of hitting path limits on Mac, which was previously an issue. |
danmoseley
added
the
area-app-model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-Pick #615
Remove extra subfolders from session temp folder path
Ensure the session folder is created with appropriate Unix permissions if it doesn't already exist
Check for Windows for proper CreateDirectory method
Remove extra using