READMEs for Service Discovery #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEvangelist
approved these changes
Nov 14, 2023
src/Microsoft.Extensions.ServiceDiscovery.Abstractions/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Feedback & contributing | ||
|
|
||
| https://github.com/dotnet/aspire |
There was a problem hiding this comment.
Why not link to the issues tab, perhaps with as specific issue template? Or a discussion board, or maybe a Discord channel? Are there any plans for any of those things? The contributing.md talks nothing about the GitHub open-source flow, or expectations dev should have coming to the repo. We should really make it feel a bit more inviting.
| @@ -0,0 +1,63 @@ | |||
| # Microsoft.Extensions.ServiceDiscovery.Dns | |||
|
|
|||
| This library provides support for resolving service endpoints using DNS (Domain Name System). It provides two service endpoint resolvers: | |||
There was a problem hiding this comment.
Consider linking to NuGet, even if this README.md is used in the package itself, developers will read this on GitHub and want the link.
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187.
cc @IEvangelist