add markdown lint #809
Merged
add markdown lint #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run dotnet-aspire |
|
No pipelines are associated with this pull request. |
|
I've verified that bad markdown does break the build. One note in case it's useful to anyone -- the markdownlint extension in VS Code does not work well for me: I can't get it to respect the configuration files, so it flags things I've suppressed in files I've marked to ignore. Instead, to run markdownlint locally I did npm install -g markdownlint-cli
markdownlint -c .markdownlint.json "**/*.md"and this seems to match what happens in CI. |
|
/azp run dotnet-aspire |
|
No pipelines are associated with this pull request. |
|
/azp list |
|
No pipelines found for this repository. |
|
build broken |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
we can presumably remove this too <!-- Required as https://github.com/dotnet/runtime/pull/89509 did not get backported to .NET 8 Preview 7 -->
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" /> |
|
/azp run dotnet-aspire |
|
No pipelines are associated with this pull request. |
|
Not sure why it's not showing here, but PR has passed now: https://dev.azure.com/dnceng-public/public/_build/results?buildId=469639&view=results. Manually merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid any future broken links.