Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to Filter input in Structured Logs and Traces page #840

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

berkansasmaz
Copy link
Contributor

Resolves #755

Screenshots

Structured Logs

Screenshot 2023-11-15 at 18 52 42

Traces

Screenshot 2023-11-15 at 18 52 52

@berkansasmaz berkansasmaz changed the title Add tooltip to Filter input in Structured Logs and Traces page Add tooltip to Filter input in Structured Logs and Traces page Nov 15, 2023
@berkansasmaz
Copy link
Contributor Author

@berkansasmaz please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@smitpatel
Copy link
Contributor

Need to check if filter apply to field mentioned in text only or other too.

@smitpatel smitpatel self-assigned this Nov 15, 2023
@smitpatel
Copy link
Contributor

LGTM to me. @tlmii - Can you give another set of eyes?

@tlmii
Copy link
Member

tlmii commented Nov 15, 2023

Yep, will respond this afternoon.

We do not need a wrapper to add a ToolTip to an input field.
@tlmii tlmii merged commit 6464fea into dotnet:main Nov 16, 2023
3 checks passed
@tlmii
Copy link
Member

tlmii commented Nov 16, 2023

Thanks again for the contribution, @berkansasmaz!

@berkansasmaz berkansasmaz deleted the berkan/filter branch November 16, 2023 11:33
@berkansasmaz
Copy link
Contributor Author

berkansasmaz commented Nov 16, 2023

Thanks again for the contribution, @berkansasmaz!

I thank you very much for your interest and concern. My first experience of contributing to the dotnet organization was great and even a small contribution made me feel very good, thank you again, .NET team!

See you next time 👋

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants