Remove check for dotnet.exe from startvs.cmd. #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Nov 16, 2023
|
The check guards against attempts to start VS without restoring the toolset first. The change also presumes .NET 8 is installed globally, which is not necessarily the correct assumption. |
|
Unfortunately |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is not helpful. At points in time where we are running against stable bits (like 8.0.100 RTM) the
.\restore.cmdscript won't actually install a repo local copy of .NET, and so this path will never exist. We may as well ditch the check.