Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for comment handling in launchSettings.json #938

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Add support for comment handling in launchSettings.json #938

merged 5 commits into from
Nov 17, 2023

Commits on Nov 17, 2023

  1. Closes: dotnet#772

    @kiapanahi
    kiapanahi authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    88d077d View commit details
    Browse the repository at this point in the history

  2. Add test to assert LaunchSetttingsSerializerContext does not throw wh… 

    …en json has comments in it.
    @kiapanahi
    kiapanahi committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2601dd4 View commit details
    Browse the repository at this point in the history

  3. Update tests/Aspire.Hosting.Tests/LaunchSettingsSerializerContextTest… 

    …s.cs

Co-authored-by: Dan Moseley <[email protected]>
    @kiapanahi @danmoseley
    kiapanahi and danmoseley authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    65292a1 View commit details
    Browse the repository at this point in the history

  4. Add blank line after the namespace

    @kiapanahi
    kiapanahi authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    cb410cd View commit details
    Browse the repository at this point in the history

  5. fix: Remove excessive parens

    @kiapanahi
    kiapanahi authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6e9df52 View commit details
    Browse the repository at this point in the history