Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dotnet8 feed comment #939

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Remove dotnet8 feed comment #939

merged 2 commits into from
Nov 17, 2023

Conversation

eerhardt
Copy link
Member

This is no longer needed.

@eerhardt
Remove dotnet8 feed
30781d4 
This is no longer needed.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 17, 2023
@eerhardt eerhardt added area-engineering-systems and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 17, 2023
@eerhardt eerhardt mentioned this pull request Nov 17, 2023
Merged
@eerhardt
Copy link
Member Author

error NU1102: Unable to find package Microsoft.Extensions.Http.Resilience with version (>= 8.1.0-preview.23565.2) [D:\a_work\1\s.dotnet\sdk\8.0.100\NuGet.targets]

Hmm, this built on my machine, but I had the package already cached. I guess this feed is needed.

This error does touch on the servicing conversation though. Are we guaranteed that Microsoft.Extensions.Http.Resilience version 8.1.0 will ship on nuget.org before we ship our preview2? cc @joperezr

@eerhardt eerhardt changed the title Remove dotnet8 feed Remove dotnet8 feed comment Nov 17, 2023
@mmitche
Copy link
Member

mmitche commented Nov 17, 2023

/azp where

@azure-pipelines Azure Pipelines
Copy link

Azure DevOps orgs getting events for this repository:

@joperezr
Copy link
Member

This error does touch on the servicing conversation though. Are we guaranteed that Microsoft.Extensions.Http.Resilience version 8.1.0 will ship on nuget.org before we ship our preview2? cc @joperezr

The current plan is to ship 8.1.0 Jan 9th.

@eerhardt
Copy link
Member Author

This error does touch on the servicing conversation though. Are we guaranteed that Microsoft.Extensions.Http.Resilience version 8.1.0 will ship on nuget.org before we ship our preview2? cc @joperezr

The current plan is to ship 8.1.0 Jan 9th.

Sounds like we will need to back out updating this reference then.

@danmoseley
Copy link
Member

merging as certainly the comment is not relevant any more.

@danmoseley danmoseley merged commit f4a75f3 into dotnet:main Nov 17, 2023
3 checks passed
@eerhardt eerhardt deleted the UpdateNugetconfig branch November 17, 2023 23:35
@eerhardt eerhardt mentioned this pull request Nov 17, 2023
Closed
@eerhardt
Copy link
Member Author

This error does touch on the servicing conversation though. Are we guaranteed that Microsoft.Extensions.Http.Resilience version 8.1.0 will ship on nuget.org before we ship our preview2? cc @joperezr

The current plan is to ship 8.1.0 Jan 9th.

Sounds like we will need to back out updating this reference then.

I've opened #942 for this.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@joperezr joperezr Awaiting requested review from joperezr

Assignees
No one assigned
Labels
area-engineering-systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerhardt @mmitche @joperezr @danmoseley