Add unique project capability to workload SDK #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
vijayrkn
reviewed
Nov 20, 2023
BillHiebert
approved these changes
Nov 27, 2023
| @@ -11,6 +11,7 @@ | |||
| <ItemGroup> | |||
| <ProjectCapability Include="DynamicFileNesting" /> | |||
| <ProjectCapability Include="DynamicFileNestingEnabled" /> | |||
| <ProjectCapability Include="AspireOrchestration" /> | |||
There was a problem hiding this comment.
Should we tie all our tooling to this capability rather than the "Aspire" one?
There was a problem hiding this comment.
If the tooling isn't tightly coupled to the Aspire.Hosting assembly being restored, you can rely on this before restore completes. If you do have something that's tied to Aspire.Hosting in some way, the existing Aspire capability is probably the safer option in that case.
There was a problem hiding this comment.
@phenning - For the readme support, can we switch to this capability?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a unique project capability to the Aspire.Hosting.Sdk workload SDK to allow tooling to identify Aspire projects before project restore.