Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DurationFormatterTests culture aware #968

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Make DurationFormatterTests culture aware #968

merged 1 commit into from
Nov 27, 2023

Conversation

andrevlins
Copy link
Contributor

Before these changes, the DurationFormatterTests class contained some tests that failed to run because of decimal formatting that did not take culture into account.

DamianEdwards
DamianEdwards approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smitpatel smitpatel merged commit 8cf2f1e into dotnet:main Nov 27, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrevlins @DamianEdwards @smitpatel