Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more components/resources to smoke test. #989

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add more components/resources to smoke test. #989

merged 1 commit into from
Nov 24, 2023

Conversation

mitchdenny
Copy link
Member

Adding more components/resources to smoke test.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 22, 2023
@mitchdenny mitchdenny self-assigned this Nov 22, 2023
@mitchdenny mitchdenny merged commit fd3c41b into main Nov 24, 2023
3 checks passed
@mitchdenny mitchdenny deleted the add-mysql-to-smoke-test branch November 24, 2023 08:21
@Meir017
Copy link
Contributor

Meir017 commented Nov 24, 2023

how are we verifying that the container dependencies are ready to receive connections?
in the testcontainers project they have the concept of waiting strategies, in redis they wait for the command redis-cli ping to return successfully https://github.com/testcontainers/testcontainers-dotnet/blob/develop/src/Testcontainers.Redis/RedisBuilder.cs

andrevlins pushed a commit to andrevlins/aspire that referenced this pull request Nov 24, 2023
@mitchdenny @andrevlins
Add more components/resources to smoke test. (dotnet#989)
f9cd28f
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Meir017 Meir017 Meir017 left review comments

@davidfowl davidfowl davidfowl approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees

@mitchdenny mitchdenny

Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @Meir017 @davidfowl