Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose Circuits on graceful disconnect #12197

Closed
rynowak opened this issue Jul 15, 2019 · 1 comment
Closed

Dispose Circuits on graceful disconnect #12197

rynowak opened this issue Jul 15, 2019 · 1 comment
Assignees
@javiercn
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
3.0.0-preview9

Comments

@rynowak
Copy link
Member

rynowak commented Jul 15, 2019 •
edited
Loading

We should be able to know the difference between a graceful disconnect and network-related disconnect. When the disconnect is graceful, it would be greatly beneficial to remove the circuit directly and bypass the disconnected pool.
@rynowak rynowak added the area-blazor Includes: Blazor, Razor Components label Jul 15, 2019
@rynowak rynowak added this to the 3.0.0-preview9 milestone Jul 15, 2019
@rynowak rynowak added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jul 15, 2019
@danroth27 danroth27 mentioned this issue Jul 15, 2019
Closed
28 tasks
@mkArtakMSFT
Copy link
Member

Let's cut this work if it turns out to be bigger than cost: S.

javiercn added a commit that referenced this issue Jul 31, 2019
@javiercn
[Blazor][Fixes #12197] Dispose the circuit on graceful disconnections (…
7a0a286 
…#12449)

* Immediately releases the circuit when the client disconnects gracefully.
* This functionality is limited to websockets.
* We are able to release the circuit in the following situations:
  * The user closes the browser.
  * The user navigates away.
  * The user reloads the page.
@mkArtakMSFT mkArtakMSFT added Done This issue has been fixed and removed Working labels Jul 31, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
3.0.0-preview9
Development

No branches or pull requests
3 participants
@rynowak @javiercn @mkArtakMSFT