Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TagHelper discovery private property metadata workaround #12291

Closed
NTaylorMullen opened this issue Jul 17, 2019 · 0 comments
Closed

Remove TagHelper discovery private property metadata workaround #12291

NTaylorMullen opened this issue Jul 17, 2019 · 0 comments
Assignees
@NTaylorMullen
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
3.0.0-preview9

Comments

@NTaylorMullen
Copy link
Contributor

We currently do some hackery in order to convince Roslyn to pull private property metadata information here.

We should remove this in preview9 since we've added an analyzer in preview8 to warn for non-public usages of Component parameters.

This is tracking work initially mentioned here.
@NTaylorMullen NTaylorMullen added 1 - Ready enhancement This issue represents an ask for new feature or an enhancement to an existing one area-blazor Includes: Blazor, Razor Components labels Jul 17, 2019
@NTaylorMullen NTaylorMullen added this to the 3.0.0-preview9 milestone Jul 17, 2019
@NTaylorMullen NTaylorMullen self-assigned this Jul 17, 2019
@rynowak rynowak mentioned this issue Jul 17, 2019
Closed
10 tasks
NTaylorMullen added a commit to dotnet/razor that referenced this issue Jul 30, 2019
@NTaylorMullen
Require public component parameters.
122b4cf 
- Prior to this a user could have private, protected or public parameters. We now require public and plan to update analyzers to enforce good usage of public component parameters.
- Removed private `ComponentTagHelperDescriptorProvider` workaround. meta data workaround since we no longer operate on private parameters.
- Updated existing tests to not have private parameter setters. I missed these in my last pass.
- Added two new tests to validate parameters which are private or have private setters are ignored.

dotnet/aspnetcore#12291
NTaylorMullen added a commit to dotnet/razor that referenced this issue Jul 30, 2019
@NTaylorMullen
Require public component parameters and remove private metadata worka…
a9ca1f9 
…round

- Prior to this a user could have private, protected or public parameters. We now require public and plan to update analyzers to enforce good usage of public component parameters.
- Removed private `ComponentTagHelperDescriptorProvider` workaround. meta data workaround since we no longer operate on private parameters.
- Updated existing tests to not have private parameter setters. I missed these in my last pass.
- Added two new tests to validate parameters which are private or have private setters are ignored.

dotnet/aspnetcore#12291
@NTaylorMullen NTaylorMullen mentioned this issue Jul 30, 2019
Merged
NTaylorMullen added a commit to dotnet/razor that referenced this issue Jul 31, 2019
@NTaylorMullen
Require public component parameters and remove private metadata worka…
bb543aa 
…round

- Prior to this a user could have private, protected or public parameters. We now require public and plan to update analyzers to enforce good usage of public component parameters.
- Removed private `ComponentTagHelperDescriptorProvider` workaround. meta data workaround since we no longer operate on private parameters.
- Updated existing tests to not have private parameter setters. I missed these in my last pass.
- Added two new tests to validate parameters which are private or have private setters are ignored.

dotnet/aspnetcore#12291
@NTaylorMullen NTaylorMullen added Done This issue has been fixed and removed Working labels Jul 31, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
3.0.0-preview9
Development

No branches or pull requests
1 participant
@NTaylorMullen