Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project.json to use array for code, exclude, resource and shared #47

Closed
keichinger opened this issue May 25, 2014 · 2 comments
Closed

Comments

@keichinger
Copy link

Browsing through the Project.json examples I was wondering why the said options are using strings instead of arrays, especially in the Entity Framework project.json example

{
  "code": "**\\*.cs;..\\Shared\\*.cs"
}

This reminds me of %PATH% on Windows or Unix/Linux and I personally find it really hard to read it. Also it introduce an additional step for me to split that string to get all paths.

So my proposal here would be to use a simple array, which should be not only easier to read but also easier to parse.

{
  "code": [
    "**\\*.cs",
    "..\\Shared\\*.cs"
  ]
}

This should also apply to other options such as exclude, resource and shared as I assume that they allow us to specify multiple values if required.

{
  "code": [
    "**\\*.cs",
    "..\\Shared\\*.cs"
  ],
  "exclude": [
    "buggy/**/*.cs"
  ],
  "resources": [
    "embed/**/*.*"
  ]
}
@davidfowl
Copy link
Member

Already tracking this aspnet/dnx#133

@keichinger
Copy link
Author

Oh, I haven't seen that. Sorry about that.
Good that there's already an issue about that :)

ryanbrandenburg pushed a commit that referenced this issue Nov 16, 2018
Updated method to return CreateUserAdmin and Configuration method to ret...
ryanbrandenburg pushed a commit that referenced this issue Nov 19, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 19, 2018
natemcmaster pushed a commit that referenced this issue Nov 30, 2018
Fix missing docs in 'RequestCultureFeature'
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants