Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip several Http3RequestTests #50833

Closed
SteveSandersonMS opened this issue Sep 20, 2023 · 1 comment · Fixed by #51668
Closed

Skip several Http3RequestTests #50833

SteveSandersonMS opened this issue Sep 20, 2023 · 1 comment · Fixed by #51668
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed

Comments

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Sep 20, 2023

Failing Test(s)

  • Interop.FunctionalTests.Http3.Http3RequestTests.POST_ServerCompletesWithoutReadingRequestBody_ClientGetsResponse
  • Interop.FunctionalTests.Http3.Http3RequestTests.POST_Expect100Continue_Get100Continue
  • Interop.FunctionalTests.Http3.Http3RequestTests.POST_ClientCancellationBidirectional_RequestAbortRaised(Http3)
  • Interop.FunctionalTests.Http3.Http3RequestTests.POST_Bidirectional_LargeData_Cancellation_Error(Http3)

Based on the conversation at #50362, it seems like we already know what's needed to fix this, but I'm quarantining anyway because we're getting quite behind on merging dependency updates and I'm trying to avoid leaving a huge backlog for the next build ops person. Hope that's OK.

We're skipping instead of quarantining because these time out, and we don't want to time out the quarantine test runs.

Error Message

System.TimeoutException : The operation has timed out.
System.Threading.Tasks.TaskCanceledException : The operation was canceled.

Stacktrace

   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken)
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken)
   at System.Net.Http.Http3Connection.SendAsync(HttpRequestMessage request, Int64 queueStartingTimestamp, CancellationToken cancellationToken)
   at System.Net.Http.Http3Connection.SendAsync(HttpRequestMessage request, Int64 queueStartingTimestamp, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.TrySendUsingHttp3Async(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber)
   at Interop.FunctionalTests.Http3.Http3RequestTests.POST_Expect100Continue_Get100Continue() in /_/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs:line 732
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at System.Net.Quic.ResettableValueTaskSource.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Quic.QuicStream.ReadAsync(Memory`1 buffer, CancellationToken cancellationToken)
   at System.Net.Http.Http3RequestStream.ReadFrameEnvelopeAsync(CancellationToken cancellationToken)
   at System.Net.Http.Http3RequestStream.ReadResponseAsync(CancellationToken cancellationToken)
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken)

Logs


Build

https://dev.azure.com/dnceng-public/public/_build/results?buildId=410608

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 20, 2023
SteveSandersonMS added a commit that referenced this issue Sep 20, 2023
@SteveSandersonMS SteveSandersonMS changed the title Quarantine POST_ServerCompletesWithoutReadingRequestBody_ClientGetsResponse, POST_Expect100Continue_Get100Continue Skip several Http3RequestTests Sep 20, 2023
@JamesNK
Copy link
Member

JamesNK commented Oct 26, 2023

100% over the last 30 days:

image

@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants