[Middleware] Move to GenericHost #23626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Jul 7, 2020
| { | ||
| var client = server.CreateClient(); | ||
| client.DefaultRequestHeaders.AcceptLanguage.ParseAdd("jp,ar-SA,en-US"); | ||
| var count = client.DefaultRequestHeaders.AcceptLanguage.Count; | ||
| var response = await client.GetAsync(string.Empty); | ||
| Assert.Equal(3, count); | ||
| } | ||
|
|
||
| await host.StopAsync(); |
There was a problem hiding this comment.
Remind me why you had to call stop? Why isn't Dispose good enough?
There was a problem hiding this comment.
I don't remember exactly, I think this was the issue where memory blocks were not being disposed which breaks in debug.
There was a problem hiding this comment.
That's only an issue in Kestrel and SignalR (?), not TestServer.
There was a problem hiding this comment.
Ah true, only if you use Kestrel. Want me to remove the StopAsync's then?
There was a problem hiding this comment.
Remove a few just to confirm it works without them.
There was a problem hiding this comment.
Seems to work fine. I'll remove them.
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20964
Each Middleware has its own commit
Edit:
Disposing the
IHostfor all tests is in the last commit, sorry did it as an after the fact change so it's not separated by area.