Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new host apis #23783

Merged
7 commits merged into from
Jul 11, 2020
Merged

Switch to new host apis #23783

7 commits merged into from
Jul 11, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 8, 2020

Still working through the files

@Pilchie Pilchie added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jul 8, 2020
@HaoK HaoK marked this pull request as ready for review July 10, 2020 17:55
@HaoK HaoK requested a review from Tratcher as a code owner July 10, 2020 17:55
@HaoK HaoK requested a review from BrennanConroy July 10, 2020 17:56
@HaoK
Copy link
Member Author

HaoK commented Jul 10, 2020

I think I got them all, there were a lot of tests :/

BrennanConroy
BrennanConroy approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

src/Identity/test/InMemory.Test/FunctionalTest.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/CookieTests.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/CookieTests.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/CookieTests.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/CookieTests.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/CookieTests.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/OpenIdConnect/TestServerBuilder.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/WsFederation/WsFederationTest.cs Outdated Show resolved Hide resolved
src/Security/Authentication/test/WsFederation/WsFederationTest.cs Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jul 10, 2020

Hello @HaoK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit fae3dd1 into master Jul 11, 2020
@ghost ghost deleted the haok/host branch July 11, 2020 00:56
@BrennanConroy BrennanConroy mentioned this pull request Jul 15, 2020
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HaoK @Tratcher @BrennanConroy @Pilchie