-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Routing] Move to GenericHost #24281
[Routing] Move to GenericHost #24281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Waiting for the tests to pass to merge
I found a few more:
aspnetcore/src/Http/Routing/test/FunctionalTests/Benchmarks/EndpointRoutingBenchmarkTest.cs Line 22 in 527096a
|
src/Http/Routing/test/FunctionalTests/EndpointRoutingIntegrationTest.cs
Outdated
Show resolved
Hide resolved
There's an unrelated CI build break. We'll look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Test failure seems unrelated. I've triggered a rerun.
Why aren't we using auto merge on these? |
Thanks for all these @Kahbazi ! |
Part of #20964