Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Move to GenericHost #24281

Merged
merged 5 commits into from
Jul 27, 2020

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Jul 24, 2020

Part of #20964

@Kahbazi Kahbazi requested a review from javiercn as a code owner July 24, 2020 14:42
@ghost ghost added the area-servers label Jul 24, 2020
@javiercn javiercn added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2020
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Waiting for the tests to pass to merge

@Tratcher
Copy link
Member

I found a few more:

var webHostBuilder = Program.GetWebHostBuilder(new[] { Program.EndpointRoutingScenario, });



public static IWebHostBuilder GetWebHostBuilder(string[] args)

var webHostBuilder = Benchmarks.Program.GetWebHostBuilder(args);

@Tratcher
Copy link
Member

There's an unrelated CI build break. We'll look into it.

@Tratcher Tratcher closed this Jul 25, 2020
@Tratcher Tratcher reopened this Jul 25, 2020
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Test failure seems unrelated. I've triggered a rerun.

@davidfowl
Copy link
Member

Why aren't we using auto merge on these?

@BrennanConroy BrennanConroy merged commit e893ef5 into dotnet:master Jul 27, 2020
@BrennanConroy
Copy link
Member

Thanks for all these @Kahbazi !

@Kahbazi Kahbazi deleted the kahbazi/RoutingHostBuilder branch July 27, 2020 17:17
@BrennanConroy BrennanConroy added this to the 5.0.0-rc1 milestone Jul 27, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants