Don't separately build arm64 installers #31158
Conversation
ghost
added
the
area-infrastructure
|
This will need to go into the 6.0-preview3 branch |
|
Yes all msi installers are built in the x64/x86 step. In 3.1 we needed to build it as part of arm64 build since no other installers wouldbe building. I forgot to remove that as it merged cleanly 3.1->main. |
There was a problem hiding this comment.
This won't fix the actual problem because we're currently building the targeting packs in every build job. It also sets us up for major problems in preview 3 and later because the ARM64 installers won't be included. Core issue is at https://github.com/dotnet/aspnetcore/blob/main/Directory.Build.targets#L82-L83 General problem after reverting recent problems there will be building the ARM64 installer inputs without shipping them i.e. excluding them from the asset manifest.
|
Ah I see, the change removed the duplications of |
|
I had to specifically mark Ref and Ref.Internal as packable in release/3.1 since we needed those zips built for arm64 but not any other platform. Usually all targeting pack is built together (zips and installers) in the x86/x64 leg. Hence the oddity in 3.1. However, in the 6.0 releases, there's no need for this special case. |
|
The internal build artifacts look correct and the duplication has been resolved. |
|
@JunTaoLuo I believe you need to manually forward port this to main |
This should fix BAR push.
I think we should backport this to 3.1 as well. Although the error will only surface when we need to rebuild targeting pack in servicing which is very rare.
I'm going to launch an internal build to verify the artifacts.