Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO MERGE] use a hacky way to run all the tests using new FileStream implementation #31441

Closed
wants to merge 1 commit into from

Conversation

adamsitnik
Copy link
Member

Please ignore this PR, I just want to check if the most recent changes have not broken anything in ASP.NET before we enable them by default.

@adamsitnik adamsitnik added the * NO MERGE * Do not merge this PR as long as this label is present. label Apr 1, 2021
@adamsitnik adamsitnik self-assigned this Apr 1, 2021
@davidfowl
Copy link
Member

cc @sebastienros

@BrennanConroy
Copy link
Member

FYI, I don't think this did what you wanted it to. You need to include the file in the build output otherwise it wont be included in the helix payloads and the tests wont run with this file.

You can look at https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-31441-merge-aaf0039304e34f65bb/InMemory.FunctionalTests--net6.0/console.ff293fe0.log?sv=2019-07-07&se=2021-04-21T10%3A22%3A02Z&sr=c&sp=rl&sig=bLqpPJuMj8nDmM%2BvSgHzrfD%2FcbNe04iiLWPMyuWM54k%3D where we output the files in the directory of the helix payload and that file isn't included.

@BrennanConroy
Copy link
Member

False alarm, looks like the eng folder got included, and the Directory.Build.props points to eng/.

@adamsitnik
Copy link
Member Author

@BrennanConroy thank you for ensuring that it does what I was hoping it does!

@adamsitnik
Copy link
Member Author

The change in runtime repo (dotnet/runtime#50166) has been merged, I am closing the PR.

@adamsitnik adamsitnik closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
* NO MERGE * Do not merge this PR as long as this label is present.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants