-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK #32298
Update SDK #32298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we haven't been updating the SDK on Mondays as planned in any case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I spotted some CI failures in the dotnet-api tests. Hopefully those are flakes. It looks like CI has bee rekicked now anyways.
Blocked by dotnet/msbuild#6377. |
Let's wait on the MSBuild issue investigation. Alternative is to downgrade our SDK version to one that work but that's not ideal. |
Brings in an SDK with dotnet/sdk#17290, which should fix errors like the following that come from the new razor language version: