Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK #32298

Merged
merged 3 commits into from
May 11, 2021
Merged

Update SDK #32298

merged 3 commits into from
May 11, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 30, 2021 •
edited
Loading

Brings in an SDK with dotnet/sdk#17290, which should fix errors like the following that come from the new razor language version:

##[error]/datadisks/disk1/workspace/_work/1/s/src/Components/benchmarkapps/Wasm.Performance/TestApp/Microsoft.NET.Sdk.Razor.SourceGenerators/Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator/_Pages_GridRendering_razor.cs(202,78): error CS0305: (NETCORE_ENGINEERING_TELEMETRY=Build) Using the generic type 'Grid' requires 1 type arguments

@wtgodbe wtgodbe requested review from captainsafia, javiercn and a team April 30, 2021 17:03
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 30, 2021
dougbu
dougbu approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we haven't been updating the SDK on Mondays as planned in any case.

captainsafia
captainsafia approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I spotted some CI failures in the dotnet-api tests. Hopefully those are flakes. It looks like CI has bee rekicked now anyways.

@JunTaoLuo
Copy link
Contributor

Blocked by dotnet/msbuild#6377.

@JunTaoLuo
Copy link
Contributor

Let's wait on the MSBuild issue investigation. Alternative is to downgrade our SDK version to one that work but that's not ideal.

@captainsafia captainsafia mentioned this pull request May 5, 2021
Closed
@TanayParikh TanayParikh mentioned this pull request May 5, 2021
Closed
@captainsafia captainsafia merged commit 1755ed9 into main May 11, 2021
@captainsafia captainsafia deleted the wtgodbe/SDK branch May 11, 2021 15:38
@ghost ghost added this to the 6.0-preview5 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@dougbu dougbu dougbu approved these changes

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
4 participants
@wtgodbe @JunTaoLuo @captainsafia @dougbu