Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enhanced line pragmas #33954

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Add support for enhanced line pragmas #33954

merged 3 commits into from
Jul 7, 2021

Conversation

captainsafia
Copy link
Member

No description provided.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 30, 2021
@captainsafia captainsafia force-pushed the safia/line-pragmas branch 6 times, most recently from d589a0c to 5d4ebde Compare July 6, 2021 19:34
@captainsafia captainsafia marked this pull request as ready for review July 6, 2021 22:20
@captainsafia captainsafia added the area-razor.compiler This issue is related to the Razor compiler (now external) label Jul 6, 2021
@captainsafia captainsafia requested review from NTaylorMullen and tmat and removed request for Pilchie, dougbu and javiercn July 6, 2021 22:20
dougbu
dougbu reviewed Jul 6, 2021
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
src/Analyzers/Analyzers/src/StartupAnalyzer.Diagnostics.cs Outdated Show resolved Hide resolved
pranavkm
pranavkm reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need something for cshtml files too?

src/Mvc/Mvc.Api.Analyzers/src/ApiDiagnosticDescriptors.cs Outdated Show resolved Hide resolved
src/Razor/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentRuntimeNodeWriter.cs Outdated Show resolved Hide resolved
pranavkm
pranavkm approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. The plan is to add support for cshtml files in a follow up.

@captainsafia captainsafia enabled auto-merge (squash) July 7, 2021 21:12
@captainsafia captainsafia merged commit 96cc622 into main Jul 7, 2021
@captainsafia captainsafia deleted the safia/line-pragmas branch July 7, 2021 21:40
@ghost ghost added this to the 6.0-preview7 milestone Jul 7, 2021
dougbu pushed a commit to dougbu/razor-compiler that referenced this pull request Nov 17, 2021
@captainsafia
Add support for enhanced line pragmas for Razor (dotnet/aspnetcore#33954
6c56e6d 
)

* Add support for enhanced line pragmas
* Clean up versions and remove unneeded analyzer changes
* Undo more unneeded changes and update string interop

Commit migrated from dotnet/aspnetcore@96cc62287b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu left review comments

@NTaylorMullen NTaylorMullen NTaylorMullen left review comments

@pranavkm pranavkm pranavkm approved these changes

@tmat tmat Awaiting requested review from tmat

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-razor.compiler This issue is related to the Razor compiler (now external)
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@captainsafia @pranavkm @NTaylorMullen @dougbu