Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Grant GitHub actions explicit permissions #38420

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 16, 2021

No description provided.

@dougbu dougbu requested review from jkoritzinsky, Tratcher, hoyosjs and a team November 16, 2021 00:55
@@ -3,6 +3,11 @@ on:
issue_comment:
types: [created]

permissions:
contents: write
issues: write
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need issues permission to write comments into the original PR (where a user started this workflow)

@@ -8,6 +8,11 @@ on:
# Once per day at midnight PST (8 UTC)
- cron: '0 8 * * *'

permissions:
contents: write
issues: write
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need issues permission to update #18943 when we're out-of-sync

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does contents control? Branches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does contents control? Branches?

As far as we know, that's right. See discussion in dotnet/runtime#61626. I'm imitating that plus dotnet/runtime#61637 in this PR.

dougbu added a commit to dougbu/aspnetcore that referenced this pull request Nov 16, 2021
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 16, 2021
@dougbu dougbu enabled auto-merge (squash) November 16, 2021 01:16
@dougbu dougbu merged commit f23e72e into dotnet:main Nov 16, 2021
@dougbu dougbu deleted the dougbu/grant.action.permissions/main branch November 16, 2021 02:36
dougbu added a commit that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants