-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Dispose CTS in HubConnection streaming #51137
Conversation
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@dotnet/aspnet-build can this be merged? |
Backport of #51117 to release/8.0
/cc @BrennanConroy
Dispose CTS in HubConnection streaming
Description
Fixes a memory leak in the SignalR client when using streaming.
Customer Impact
Noticed by customer when running a service with a client for multiple weeks and seeing large memory usage. Could also be seen by a more active client that makes a lot of streaming calls.
Regression?
Looks like it's been there since 3.X
Risk
Simple disposal of an object once it's done being used.
Verification
Packaging changes reviewed?