Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DenyAnonymousAuthorizationRequirement doc comment #51490

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

davhdavh
Copy link
Contributor

DenyAnonymousAuthorizationRequirement: Actual behaviour is different than class name

Description

Actual behavior of DenyAnonymousAuthorizationRequirement is different than class name implies.

Addresses #4656

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 19, 2023
@ghost
Copy link

ghost commented Oct 19, 2023

Thanks for your PR, @davhdavh. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@blowdart
Copy link
Contributor

I'm confused

Unlike what the name of the class implies, where you would expect failure if not authenticated, it instead succeeds if you are authenticated.

So, what happens if you are unauthenticated?

@davhdavh
Copy link
Contributor Author

That gets handled further up in the chain, but this particular class does not set the Fail condition

@ghost
Copy link

ghost commented Oct 31, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 31, 2023
@halter73 halter73 enabled auto-merge (squash) November 9, 2023 22:35
@halter73 halter73 changed the title doc(DenyAnonymousAuthorizationRequirement): Actual behaviour is different than class name Update DenyAnonymousAuthorizationRequirement doc comment Nov 9, 2023
@halter73 halter73 merged commit 81465f5 into dotnet:main Nov 10, 2023
25 checks passed
@ghost ghost added this to the 9.0-preview1 milestone Nov 10, 2023
@davhdavh davhdavh deleted the patch-2 branch November 10, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants