Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locker.yml #55188

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Update locker.yml #55188

merged 1 commit into from
Apr 18, 2024

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Apr 17, 2024

* Bump the Locker action version
Refer to microsoft/vscode-github-triage-actions#210

* Restrict the Locker action to dotnet org
@RussKie RussKie requested review from wtgodbe and a team as code owners April 17, 2024 23:23
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 17, 2024
@RussKie RussKie enabled auto-merge (squash) April 17, 2024 23:40
@RussKie
Copy link
Member Author

RussKie commented Apr 17, 2024

@wtgodbe there's no reason to spin builds for non-buildable changes like this. It's worth considering adding the exclusions to the ymls like the following:

 
 pr:
   branches:
     include:
     - main
     - release/*
     - feature/*
+  paths:
+    include:
+      - '*'
+    exclude:
+      - eng/Version.Details.xml
+      - .github/*
+      - docs/*
+      - CODE_OF_CONDUCT.md
+      - CONTRIBUTING.md
+      - README.md
+      - SECURITY.md
+      - LICENSE.TXT
+      - PATENTS.TXT
+      - THIRD-PARTY-NOTICES.TXT

I'm happy to send PRs, if you like.

@RussKie RussKie merged commit 561f135 into main Apr 18, 2024
22 checks passed
@RussKie RussKie deleted the RussKie-patch-1 branch April 18, 2024 01:17
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 18, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Apr 22, 2024

It's worth considering adding the exclusions to the ymls like the following:

@RussKie we tried that, but then we can't make aspnetcore-ci a required check, because the check doesn't run on those PRs. That means someone with admin perms has to force-merge any PRs on those files, which isn't really any better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants