Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/source-build-reference-packages #56771

Merged
merged 5 commits into from
Jul 15, 2024
Merged

[main] Update dependencies from dotnet/source-build-reference-packages #56771

merged 5 commits into from
Jul 15, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 13, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: 34ebb389-daeb-4237-045c-08db4c01eb9e
  • Build: 20240712.1
  • Date Produced: July 12, 2024 6:36:57 PM UTC
  • Commit: 2fa4c4f8c0b17b48d2f37839563d6862d1974736
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
3ddfff9 
…ence-packages build 20240712.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24358.1 -> To Version 9.0.0-alpha.1.24362.1
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners July 13, 2024 12:19
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 13, 2024
dotnet-policy-service[bot]
dotnet-policy-service bot approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
ab22c20 
…ence-packages build 20240712.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24358.1 -> To Version 9.0.0-alpha.1.24362.1
@javiercn
Copy link
Member

/azp run aspnetcore-ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@javiercn
Copy link
Member

javiercn commented Jul 15, 2024 •
edited
Loading

@dotnet/source-build-internal Can you assist here?

@captainsafia any thoughts (since you are likely more familiar with this area)

I've looked at the new pre-builts and they seem to come from the Analyzer's we have, so I suspect we need to take a runtime dependency update that brings in new compiler versions before this PR can be unblocked?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
c661ab6 
…ence-packages build 20240712.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24358.1 -> To Version 9.0.0-alpha.1.24362.1
@mthalman
Copy link
Member

mthalman commented Jul 15, 2024 •
edited
Loading

@MichaelSimons - This looks to be caused by your changes in dotnet/source-build-reference-packages#979. I'm assuming these packages that were removed aren't being used in the full VMR build, so any dependencies that still exist in individual repos, like aspnetcore, should just be added as prebuilt exclusions?

@MichaelSimons
Copy link
Member

@MichaelSimons - This looks to be caused by your changes in dotnet/source-build-reference-packages#979. I'm assuming these packages that were removed aren't being used in the full VMR build, so any dependencies that still exist in individual repos, like aspnetcore, should just be added as prebuilt exclusions?

That is correct on all parts.

@mthalman mthalman requested a review from a team as a code owner July 15, 2024 14:49
@javiercn
Copy link
Member

/azp run aspnetcore-ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MackinnonBuck MackinnonBuck merged commit fce2441 into main Jul 15, 2024
26 checks passed
@MackinnonBuck MackinnonBuck deleted the darc-main-ef4e9357-a003-4f9a-85ea-751fd3a840d9 branch July 15, 2024 21:20
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 15, 2024
@lewing lewing mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

@dotnet-policy-service Dotnet Policy Service dotnet-policy-service approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
9.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@javiercn @mthalman @MichaelSimons @MackinnonBuck