This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Add @page directive #244
Merged
Add @page directive #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
approved these changes
Mar 12, 2018
| builder => | ||
| { | ||
| builder.AddStringToken(Resources.PageDirective_RouteToken_Name, Resources.PageDirective_RouteToken_Description); | ||
| builder.Usage = DirectiveUsage.FileScopedSinglyOccurring; |
There was a problem hiding this comment.
Could we have FileScopedMultipleOccurring? There will be cases where people want to define more than one URL pattern that maps to the same component.
|
|
||
| // Only process the first directive occurrence. The parser will have already flagged multiple | ||
| // usages as errors. | ||
| var pageDirective = (DirectiveIntermediateNode)directives[0].Node; |
There was a problem hiding this comment.
As previous comment, would be good if we allowed multiple.
|
|
||
| namespace Microsoft.AspNetCore.Blazor.Components | ||
| { | ||
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = true)] |
rynowak
force-pushed
the
rynowak/page-directive
branch
from
83b5acc
to
e5dce13
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the @page directive and support for specifying routes in components
at compile time.
For now the route is required and must begin with a leading /.