Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

lambda fixes #321

Merged
merged 2 commits into from
Mar 21, 2018
Merged

lambda fixes #321

merged 2 commits into from
Mar 21, 2018

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Mar 21, 2018

No description provided.

Most versions of NPM in use always use LF for line endings anyway.
Forcing LF on windows should limit the number of no-op changes.

This issue has been fixed in NPM
(see npm/npm#1716) but not everyone will have
the fix.
This change removes the magic 'auto-lambda' feature that has some
unconvincing UX.

Also working around a razor bug where explicit expressions are lowered
incorrectly. This should make it possible to write code like:

<Foo Bar="@(e => { OnChanged(e); })" />
@rynowak
Copy link
Member Author

rynowak commented Mar 21, 2018

Tested this out with Flightfinder and different syntaxes and it all seems pretty good.

Also noticed that <Search OnSearch="async (e) => await Task.Delay(50)" /> works pretty well also.

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent - thanks for the quick turnaround!

@rynowak rynowak merged commit 73ef42e into dev Mar 21, 2018
@rynowak
Copy link
Member Author

rynowak commented Mar 21, 2018

Will cherry pick to release asap

@rynowak rynowak deleted the rynowak/lambda branch March 22, 2018 00:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants