Skip to content
/ cecil Public
forked from jbevain/cecil
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic attributes #36

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 17, 2022

This adds support for generic attributes, added in C# 10. This is needed to fix a linker crash on runtime tests that used generic attributes: dotnet/linker#2963

Upstreaming this in jbevain#871.

@sbomer
Copy link
Member Author

sbomer commented Aug 17, 2022

@MichalStrehovsky @vitek-karas @marek-safar PTAL (I can't add reviewers)

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but looks reasonable. Nice that it already worked for the named arguments case.

Does the test also test writing? Though, I'm not too concerned about that since I assume we'll have writing coverage in the linker repo.

@sbomer
Copy link
Member Author

sbomer commented Aug 18, 2022

Yes, TestModule will test writing. I didn't look too closely at what exactly it validates, but it does some kind of round-tripping, and was hitting the same crash in the writing code before the fix.

@sbomer
Copy link
Member Author

sbomer commented Aug 22, 2022

@marek-safar would you be able to merge this? I don't have permission. Thanks!

@marek-safar marek-safar merged commit 1840b74 into dotnet:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants