This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
do not set BaseIntermediateOutputPath in temp project of dotnet install to 2.1.4xx #9122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use MsBuildProjectExtensionsPath instead. Change the property passin by project file instead of command line. It is more reliable passing path in xml and also the timing of MsBuildProjectExtensionsPath is controlled. (Before loading SDK) Change mock fake project to use “;” instead, since c:\path contains “:”.
wli3
changed the title
wli3
changed the title
dsplaisted
approved these changes
Apr 23, 2018
There was a problem hiding this comment.
This looks fine.
In general it is still valid to use BaseIntermediateOutputPath to control where the NuGet output goes as long as you do so before the common props are evaluated (which is where you also have to set MSBuildProjectExtensionsPath for it to work).
|
Customer scenario After NuGet/NuGet.Client#2131 and dotnet/msbuild#3059 MSBuildProjectExtensionsPath is the more accurate property to set to only redirect nuget's output Bugs this fixes https://github.com/dotnet/cli/issues/9124 Workarounds, if any N/A Risk low Performance impact no Root cause analysis Dependency design change. How was the bug found? Issued by NuGet @MattGertz ask mode for 15.8 |
peterhuene
approved these changes
Apr 24, 2018
wli3
pushed a commit
to wli3/cli
that referenced
this pull request
Jun 18, 2018
…ll (dotnet#9122) Should use MsBuildProjectExtensionsPath instead. Change the property passin by project file instead of command line. It is more reliable passing path in xml and also the timing of MsBuildProjectExtensionsPath is controlled. (Before loading SDK) Change mock fake project to use “;” instead, since c:\path contains “:”.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use MsBuildProjectExtensionsPath instead.