Disable System.CommandLine trimming for source-build #2149
Conversation
|
Other option might be to disable targeting net7 in source build (and targeting net8). I don't have a strong opinion, but I think @MichaelSimons may think that not targeting net7 is the right way to go, because that avoids bringing in the net7 targeting pack at all. |
|
This doesn't seem like a long term change that we would want. Is my understanding correct, that this wouldn't be an issue once net 8.0? If so, I like @mmitche's suggestion of conditionally targeting net8.0 for source-build. FYI, This repo has not flowed into the product repos for some time now. IIRC this is because of the number of the breaking changes being made. Any changes needed now for source-build should be checked in like this but you will also need to create a source-build patch. |
It does look like they are iterating in sdk on the update. Not sure when it's expected to get checked in though. |
|
Ok, I'll close this for now and go with the approach of targeting net8.0 instead. |
When attempting to enable PVP flow for the command-line-api, a prebuilt was detected for
Microsoft.NET.ILLink.Tasks.7.0.100-1.23062.2. This occurs as a result of the enablement of trimming for the System.CommandLine project.To resolve this, I've changed the configuration to only enable trimming when not running source-build. I initially attempted to only apply this condition to the
EnableTrimAnalyzerproperty but that did not prevent the loading ofMicrosoft.NET.ILLink.Tasks.cc @jonsequitur @mmitche @MichaelSimons