-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add travisci example (Ubuntu 14.04 and Mac OS X 10.11) #460
Conversation
@enricosada good one. Can I bother you with a few questions?
|
I got mixed experiences with packages and installer during development of dotnet/cli, i know preview1 is more stable now. And it's the same install for osx and ubuntu atm, because
I used to execute the script before in travis/appveyor. i can do that like there also with a oneliner if you want. But there is little value to use it for me. it's just curl + unzip. Maybe in windows is better the script because i cannot use the better oneliner of powershell 5, but it's easy to follow. If i use the script:
Anyway, as you wish, np for me about one way or another, i can update both pr. |
anyway @blackdwarf can you pls enable both travisci and appveyor build of this repo? so we can test these pr before merge. |
Same questions as #461. |
People need that as example how to install .net core sdk in appveyor, not how to do build.
Yes by design of travis that's the default where it's expected (and where developer search it).
sure, i use .net core sdk for open source project, that's really easy to update it |
before install: | ||
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update ; fi | ||
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install openssl ; fi | ||
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew link --force openssl ; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can be wrapped in one if
like this: https://github.com/maxmind/GeoIP2-dotnet/blob/bc0a878/.travis.yml#L31-L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ version in different repo: https://github.com/maxmind/MaxMind-DB-Reader-dotnet/blob/1701f6a/.travis.yml :)
@enricosada the same request as for the #461 . Can you add this to the "Using CLI with CI" doc? |
i'll do that now @blackdwarf |
done @blackdwarf @cartermp . Pls @mairaw can you review this too? I really appreciated the review of the other pr |
@@ -64,7 +64,44 @@ in the [CLI repo](https://github.com/dotnet/core/blob/master/Documentation/prere | |||
The below sections show examples of configurations using the mentioned CI SaaS offerings. | |||
|
|||
### TravisCI | |||
**TODO** | |||
|
|||
The [travis-ci](https://travis-ci.org/) doesn't have the .NET Core SDK preview1 installed by default, but can be added to any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to become "Preview 2".
@enricosada thanks much for doing this! 😄 I've left some comments, mostly around the links and the versions. As Preview 2 of the SDK is going live today, we should change to point to these. |
yes, i'll update it when the |
@blackdwarf if you want we can fix the links after the |
@enricosada Once you get the links updated for Preview 2 we can merge this 😄. |
travisci now support .net core sdk with `dotnet` key on language `csharp`
ed3f44f
to
5925b28
Compare
@richlander @cartermp @blackdwarf sry for long delay, the previous install script was ok ( i just had some intermmittent issues with ssl/crypto after install from script. dunno why) and i was trying to cleanup more. now travis support the rebased to master, updated docs, and added example |
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@@ -64,7 +64,17 @@ in the [CLI repo](https://github.com/dotnet/core/blob/master/Documentation/prere | |||
The below sections show examples of configurations using the mentioned CI SaaS offerings. | |||
|
|||
### TravisCI | |||
**TODO** | |||
|
|||
The [travis-ci](https://travis-ci.org/) can be configured to install the .NET Core SDK using the language `csharp` and `dotnet` key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing period on the end of the sentence
also wondering if this would read better like this:
...using the csharp
language and the dotnet
key.
Thanks @enricosada. I've removed the WIP label and left a few comments. I'll let the guys give the thumbs up on this one. |
@mairaw thx for review, changed it as you suggested. |
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@blackdwarf can you finish reviewing this? Thanks! |
|
||
matrix: | ||
include: | ||
- os: linux # Ubuntu 14.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enricosada does Travis have Xenial yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, i dont see that in documentation, just Trusty (14) and Precise (12), and no news in latest changelog https://docs.travis-ci.com/user/build-environment-updates/2016-08-24/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok then. 😃
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
LGTM. Are we good to merge @blackdwarf? |
Thanks @enricosada! |
ref https://github.com/dotnet/cli/issues/2113
it add an example travisci to build:
It use .NET Core SDK binaries, so it's pretty much curl sdk | unzip to a subdirectory
.dotnetsdk
and add that to PATHI used the .net core sdk binaries instead of pkg because are easier to test locally, no need for sudo etc.
The script from dotnet/cli repo is not used because it's easier to just download and unzip, and also it's easier to understand.
i am pretty sure for osx deps (because of docs about brew)
But i am not sure about ubuntu (see apt deps) because these were needed some months ago, maybe now are not.
It use
generic
as travis language, so it's possibile to copy before_install, install in any travis, not onlycsharp
./cc @blackdwarf @akoeplinger