Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add travisci example (Ubuntu 14.04 and Mac OS X 10.11) #460

Merged
merged 4 commits into from
Sep 9, 2016
Merged

add travisci example (Ubuntu 14.04 and Mac OS X 10.11) #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5925b28
add travisci example (Ubuntu 14.04 and Mac OS X 10.11)
enricosada May 24, 2016
f8df124
feedback
enricosada Sep 7, 2016
df8eca8
fix typo
enricosada Sep 8, 2016
2892312
cleanup travis script
enricosada Sep 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
language: csharp

matrix:
include:
- os: linux # Ubuntu 14.04
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enricosada does Travis have Xenial yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, i dont see that in documentation, just Trusty (14) and Precise (12), and no news in latest changelog https://docs.travis-ci.com/user/build-environment-updates/2016-08-24/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok then. 😃

dist: trusty
sudo: required
dotnet: 1.0.0-preview2-003121
- os: osx # OSX 10.11
osx_image: xcode7.2
dotnet: 1.0.0-preview2-003121

script:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is a sample of commands that you can run, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each line is a shell command, ( you can do - which dotnet )
travis by default run dotnet --info after install so the log always contains the version info
These are just a familiar smoke test, if the use know travis it's normal

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Maybe then we should run dotnet --version as that will not inflate the log? I'm fine either way, whatever is best practice on Travis in general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dotnet --info it's already done by travis after the install the .net core sdk.
I'll remove it from script so it's clear is useless

# dotnet info
- dotnet --info
# Run dotnet new
- mkdir -p "test/test-dotnet-new" && pushd "test/test-dotnet-new"
- dotnet new
- dotnet restore
- dotnet --verbose run a b
- popd
12 changes: 11 additions & 1 deletion docs/core/tools/using-ci-with-cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,17 @@ in the [CLI repo](https://github.com/dotnet/core/blob/master/Documentation/prere
The below sections show examples of configurations using the mentioned CI SaaS offerings.

### TravisCI
**TODO**

The [travis-ci](https://travis-ci.org/) can be configured to install the .NET Core SDK using the language `csharp` and `dotnet` key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing period on the end of the sentence

also wondering if this would read better like this:
...using the csharp language and the dotnet key.


Just use:

```yaml
dotnet: 1.0.0-preview2-003121
```

Travis can run both `osx` (OSX 10.11) and `linux` ( Ubuntu 14.04 ) job in a build matrix, see [example .travis.yml](https://github.com/dotnet/core-docs/blob/master/.travis.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSX -> OS X

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For accuracy, the official name of platform has been changed to macOS. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been using macOS when we refer to the platform in a generic way @am11. However, when we're talking about El Capitan, we still use OS X since that's the right branding.

for more info.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info -> information


### AppVeyor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR: Line 81 talks about preview1. shouldn't that be preview 2? That line is also missing the period.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw good catch, fixed

Expand Down