Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-diff between 7.0-preview2 and 7.0-preview3 #7396

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

carlossanlop
Copy link
Member

The bugs we found in the API diffs for Preview1 and Preview2 were fixed here: dotnet/arcade#9172

ASP.NET: @dotnet/aspnet-api-review

WinForms: @merriemcgaw @RussKie

WPF: @dreddy-work @RussKie

Libraries: @danmoseley @jeffhandley @karelz @ericstj @stephentoub

@dotnet/area-extensions-filesystem
@dotnet/area-extensions-hosting
@dotnet/area-extensions-logging
@dotnet/area-extensions-primitives
@dotnet/area-system-runtime
@dotnet/area-system-numerics
@dotnet/area-system-diagnostics-activity
System.Net: @dotnet/ncl
@dotnet/interop-contrib
@dotnet/area-system-security
@dotnet/area-system-text-regularexpressions

@tarekgh
Copy link
Member

tarekgh commented Apr 24, 2022

I am seeing something strange in the system namespace. here is some example:

-        public static DateOnly MaxValue { get; }
+        static DateOnly MaxValue { get; }

Is this intentional?

@tarekgh
Copy link
Member

tarekgh commented Apr 24, 2022

I am not seeing System.Composition.Hosting is included. Here is the new exposed APIs #7108 (comment). Or we are not including the OOB libraries?

@tarekgh
Copy link
Member

tarekgh commented Apr 24, 2022

The following System.Diagnostics APIs LGTM.

     public class Activity : IDisposable {
+        public bool HasRemoteParent { get; }
     }
     public readonly struct ActivityCreationOptions<T> {
+        public string? TraceState { get; set; }
     }

Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft.WindowsDesktop.App APIs look good to me.

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime changes LGTM

Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M.E.Logging/Caching/Configuration/Primitives diff LGTM.

cc @halter73 for Hosting

@AaronRobinsonMSFT
Copy link
Member

System.Runtime.InteropServices LGTM.

@carlossanlop
Copy link
Member Author

I am not seeing System.Composition.Hosting is included. Here is the new exposed APIs #7108 (comment). Or we are not including the OOB libraries?

That's my understanding, @tarekgh - We do not include OOBs in this report.

Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto LGTM

@carlossanlop carlossanlop merged commit c219d46 into dotnet:main Apr 26, 2022
@carlossanlop carlossanlop deleted the ApiDiffPrev3 branch April 26, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants