Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API diff between .NET 9 Preview 7 and .NET 9 RC 1 #9497

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

carlossanlop
Copy link
Member

Repo area owners:

Libraries area owners:

  • System @dotnet/area-system-runtime @dotnet/area-system-console
  • System.Collections @dotnet/area-system-collections
  • System.Drawing @dotnet/area-system-drawing @lonitra @merriemcgaw @JeremyKuhne
  • System.IO.Compression @dotnet/area-system-io-compression @buyaa-n
  • System.Net @dotnet/ncl
  • System.Reflection.Emit @dotnet/area-system-reflection-emit
  • System.Reflection.Metadata @dotnet/area-system-reflection-metadata
  • System.Runtime.Intrinsics @dotnet/area-system-runtime-intrinsics
  • System.Security @dotnet/area-system-security

Known api-diff tool issues:

If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Net LGTM

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Reflection.Metadata LGTM, thank you @carlossanlop !

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Collections LGTM

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also include the JsonElement.GetPropertyCount that was retroactively added to RC1 via dotnet/runtime#106576?

@carlossanlop
Copy link
Member Author

carlossanlop commented Sep 11, 2024

Shouldn't this also include the JsonElement.GetPropertyCount that was retroactively added to RC1 via dotnet/runtime#106576?

@eiriktsarpalis That backport dotnet/runtime#106576 was merged into release/9.0 which from the start was pointing to RC2. I don't see any RC1 backport PRs (release/9.0-rc1) unfortunately.

@eiriktsarpalis
Copy link
Member

That backport dotnet/runtime#106576 was merged into release/9.0 which from the start was pointing to RC2. I don't see any RC1 backport PRs (release/9.0-rc1) unfortunately.

Ah good, before going OOF I was under the impression it would be merged for RC1 but I guess we missed the deadline.

Comment on lines +5 to +31
+ public sealed class BrotliCompressionOptions {
+ public BrotliCompressionOptions();
+ public int Quality { get; set; }
+ }
public sealed class BrotliStream : Stream {
+ public BrotliStream(Stream stream, BrotliCompressionOptions compressionOptions, bool leaveOpen = false);
}
public class DeflateStream : Stream {
+ public DeflateStream(Stream stream, ZLibCompressionOptions compressionOptions, bool leaveOpen = false);
}
public class GZipStream : Stream {
+ public GZipStream(Stream stream, ZLibCompressionOptions compressionOptions, bool leaveOpen = false);
}
+ public sealed class ZLibCompressionOptions {
+ public ZLibCompressionOptions();
+ public int CompressionLevel { get; set; }
+ public ZLibCompressionStrategy CompressionStrategy { get; set; }
+ }
+ public enum ZLibCompressionStrategy {
+ Default = 0,
+ Filtered = 1,
+ Fixed = 4,
+ HuffmanOnly = 2,
+ RunLengthEncoding = 3,
+ }
public sealed class ZLibStream : Stream {
+ public ZLibStream(Stream stream, ZLibCompressionOptions compressionOptions, bool leaveOpen = false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.IO.Compression part LGTM

Comment on lines +6 to +15
- public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type returnType, Type[]? parameterTypes);
+ public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type? returnType, Type[]? parameterTypes);
- public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers);
+ public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type? returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers);
- public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type returnType, Type[]? parameterTypes);
+ public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type? returnType, Type[]? parameterTypes);
- public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers);
+ public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type? returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers);
- protected abstract PropertyBuilder DefinePropertyCore(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers);
+ protected abstract PropertyBuilder DefinePropertyCore(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type? returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note that these are just a nullability change for one parameter Type returnType => Type? returnType

@@ -0,0 +1,179 @@
# System.Runtime.Intrinsics.Arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime.Intrinsics.Arm LGTM

CC. @dotnet/area-system-runtime-intrinsics, @dotnet/arm64-contrib

@@ -0,0 +1,41 @@
# System.Runtime.Intrinsics.X86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime.Intrinsics.X86 LGTM

CC. @dotnet/area-system-runtime-intrinsics

@bartonjs
Copy link
Member

System.Security.* LGTM

@carlossanlop carlossanlop merged commit 352d43f into dotnet:main Sep 12, 2024
2 of 3 checks passed
@carlossanlop carlossanlop deleted the ApiDiffRC1 branch September 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants