build-test - fix ilasm warnings caused by missing/incorrect extern assembly declarations

[4creators]

Fixes #14689

While working on #19109 fixed all ilasm warnings for priority 0 and 1 builds.

Since my editor is automatically enforcing .editorconfig coding style white space was fixed in all files which were edited (tabs -> spaces, no white space at the end of line)

Will create separate issue to track not fixed #14689 warnings - MSB3268

[4creators]

Related issue #19174

[4creators]

Failures of OSX10.12 x64 Checked Build and Test (Jit - TieredCompilation=0 JitStress=2 (JitStressRegs=3) ) are unrelated to this PR and tracked by #19190

[4creators]

@jkotas @CarolEidt @AndyAyersMS PTAL

[CarolEidt]

I don't believe that we should need to put explicit publickeytoken specifications in the IL tests (or at least not for most of them). I wonder if these are here simply because the original IL was created from ildasm, and in many cases it should probably be using .assembly extern BLAH { auto }.

[4creators]

Will fix

[4creators]

@CarolEidt Addressed review feedback PTAL

Assembly declarations have been corrected with script, if you think we can do it to all il source files I could run script for all of them. Please let me now.

[CarolEidt]

@dotnet-bot test OSX10.12 x64 Checked CoreFX Tests
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test

[CarolEidt]

if you think we can do it to all il source files I could run script for all of them. Please let me now.

I don't think it's necessary. I don't know if we have any tests that explicitly test the use of non-auto assembly declarations.

[4creators]

@CarolEidt I will replace my "Remove unnecessry assembly declaration metadata" with new version with some improvements to white space and mscorlib handling.

[CarolEidt]

LGTM - thanks!