-
Notifications
You must be signed in to change notification settings - Fork 2.7k
build-test - fix ilasm warnings caused by missing/incorrect extern assembly declarations #19188
Conversation
5e25dd6
to
40f1e6a
Compare
Related issue #19174 |
Failures of |
I don't believe that we should need to put explicit |
Will fix |
40f1e6a
to
86e5abf
Compare
@CarolEidt Addressed review feedback PTAL Assembly declarations have been corrected with script, if you think we can do it to all il source files I could run script for all of them. Please let me now. |
…n assembly declarations white space was fixed in all files which were edited (tabs -> spaces, no white space at the end of line)
86e5abf
to
8f0cc46
Compare
@dotnet-bot test OSX10.12 x64 Checked CoreFX Tests |
I don't think it's necessary. I don't know if we have any tests that explicitly test the use of non-auto assembly declarations. |
@CarolEidt I will replace my "Remove unnecessry assembly declaration metadata" with new version with some improvements to white space and mscorlib handling. |
8f0cc46
to
ff81e36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Fixes #14689
While working on #19109 fixed all ilasm warnings for priority 0 and 1 builds.
Since my editor is automatically enforcing .editorconfig coding style white space was fixed in all files which were edited (tabs -> spaces, no white space at the end of line)
Will create separate issue to track not fixed #14689 warnings - MSB3268