-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
@dotnet/dnceng I think this PR hits the same issue as #19588, there are only 7 ci jobs started for this PR (The PR was opened 12 minutes ago). |
Looks like jobs were spawned immediately after I added the last comment. |
@sandreenko I've actually seen this before, too, where jobs don't seem to spawn until commenting. We'll take a look and see if we can get a better idea of what's going on. |
@sandreenko Erm, was there something wrong with the prototype I had in https://github.com/dotnet/coreclr/issues/16472? I asked about it and got no reply. |
I wonder whether this a GitHiub live-ui issue. Did you refresh the page? |
@sandreenko In chatting with some others, this tends to be an issue with GitHub not refreshing fast enough. Leaving a comment definitely seems to be a workaround. |
To be honest I have missed that. Your prototype looks very clean and straightforward. |
d6a3216
to
71b7274
Compare
Not yet. The main goal was to replace the existing code, get it to pass existing tests and get 0 diffs. In particular I wanted the 0 diffs part because, as mentioned somewhere else, discrepancies between Fixing #18988 should be trivial - it's just a matter of checking if the size of the indir type is greater than the size of the lclvar those address you get via the value stack, if any. Right now it does not check so it behaves like the existing code.
Will do. Perhaps I should have already done so to avoid you wasting your time working on this. But I already have a bunch of opened PRs so I'm trying to be a bit more conservative with opening new ones. |
@dotnet-bot help |
Welcome to the dotnet/coreclr Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
71b7274
to
c8f8a62
Compare
@dotnet-bot test this please |
This PR is for test purpose only.