Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Runtest.py on Windows Arm(64) #20227

Merged
merged 9 commits into from
Oct 8, 2018
Merged

Conversation

jashook
Copy link

@jashook jashook commented Oct 2, 2018

This change adds incremental improvements to runtest.py

  1. Shortens runtest times on windows
  2. Corrects SequentialRuns to allow non-parallel test runs
  3. Improves same platform test runs (skips non essential parts required on cross test runs)
  4. Changes init-tools.cmd to skip restoring build tools on arm64
  5. Adds windows arm and arm64 test excludes to issues.targets

This is currently working; however, the excludes are missing for pri1 and on arm. I will remove the WIP once issues.targets is fully complete. In the meantime please feel free to review, the actual infrastructure will not change.

Jarret Shook added 2 commits October 2, 2018 09:23
1) Adds a build_test_wrappers only to build-test.sh.
2) Adds arm64 windows excludes
3) Adds printlastresults to runtest.cmd
4) corrects runsequential in runtest.sh
5) Corrects SequentialRun in runtest.py
6) Minor improvements to printing test results and copying native test binaries
tests/runtest.cmd Show resolved Hide resolved
build-test.sh Outdated
@@ -525,6 +530,7 @@ usage()
echo "rebuild - if tests have already been built - rebuild them"
echo "skipnative: skip the native tests build"
echo "skipmanaged: skip the managed section of the test build"
echp "buildtestwrappersonly - only build the test wrappers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo

@jashook
Copy link
Author

jashook commented Oct 3, 2018

Latest change gives clean pri1 run on arm64. Working on getting clean arm run now.

@jashook jashook changed the title Runtest.py on Windows Arm(64) - WIP Runtest.py on Windows Arm(64) Oct 5, 2018
@jashook
Copy link
Author

jashook commented Oct 5, 2018

Clean Pri1 run on arm, trying to figure out what is up with the unix jobs.

@jashook jashook merged commit dbf0bf1 into dotnet:master Oct 8, 2018
@jashook jashook deleted the working_arm64_testing branch October 8, 2018 16:25
echesakov added a commit that referenced this pull request Oct 24, 2018
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
echesakov added a commit that referenced this pull request Oct 24, 2018
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Work around cmd command length limit in xunit Exec task (#19095)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
echesakov added a commit that referenced this pull request Oct 25, 2018
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Work around cmd command length limit in xunit Exec task (#19095)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
echesakov added a commit that referenced this pull request Oct 26, 2018
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Work around cmd command length limit in xunit Exec task (#19095)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
A-And pushed a commit to A-And/coreclr that referenced this pull request Nov 20, 2018
* Initial infrastructure work to get arm(64) runtest.cmd working

* Add excludes and improve runtest.py

1) Adds a build_test_wrappers only to build-test.sh.
2) Adds arm64 windows excludes
3) Adds printlastresults to runtest.cmd
4) corrects runsequential in runtest.sh
5) Corrects SequentialRun in runtest.py
6) Minor improvements to printing test results and copying native test binaries

* Address pr feedback

* Add to issues targets for arm64

* Working Pri 0 testing.

* Remove unecessary common msbuild arguments

* add pri1 excludes

* Remove common msbuild args

* Fix silly python3 issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants