This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Changing Number.BigInteger and Number.NumberBuffer to directly use fixed-sized buffers #20371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @jkotas |
tannergooding
commented
Oct 11, 2018
jkotas
reviewed
Oct 11, 2018
jkotas
approved these changes
Oct 11, 2018
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Nov 2, 2018
…xed-sized buffers (dotnet#20371) * Moving Number.BigInteger to directly use a `fixed-sized buffer` * Moving Number.NumberBuffer to directly use a `fixed-sized buffer`
A-And
pushed a commit
to A-And/coreclr
that referenced
this pull request
Nov 20, 2018
…xed-sized buffers (dotnet#20371) * Moving Number.BigInteger to directly use a `fixed-sized buffer` * Moving Number.NumberBuffer to directly use a `fixed-sized buffer`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# 7.3 added support for accessing fixed-sized buffer indices without needing to pin the data first, which allows us to remove most of the helper methods we were using here.