This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup PlatformID and PlatformDetection usage #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are ~110 tests that have been disabled with an ActiveIssue for PlatformID.Linux | PlatformID.OSX. To simplify this and to avoid lots of additional churn when additional Unix-based platforms are added, I've added PlatformID.AnyUnix = Linux | OSX, and replaced all usage of Linux | OSX with just AnyUnix. When new platforms are added, we can simply add to the enum, expand the meaning of AnyUnix, and most tests meant to be disabled for Unix will automatically be disabled.
When I first added Interop.PlatformDetection while cleaning up tests for Linux, I'd added an OperatingSystem property, and the typical pattern was to compare against an enum, e.g.
```
if (Interop.PlatformDetection.OperatingSystem == Interop.OperatingSystem.Windows)
{
...
}
```
We subsequently added helper Is* properties, e.g. IsWindows, but never went back and substituted into the previous uses. This cleans that up, such that usage like the above instead becomes:
```
if (Interop.IsWindows)
{
...
}
```
|
LGTM |
ellismg
added a commit
that referenced
this pull request
Apr 30, 2015
Cleanup PlatformID and PlatformDetection usage
| @@ -12,6 +12,7 @@ public enum PlatformID | |||
| Windows = 1, | |||
| Linux = 2, | |||
| OSX = 4, | |||
| AnyUnix = Linux | OSX, | |||
| Any = Windows | Linux | OSX | |||
There was a problem hiding this comment.
Would it make sense to have Any on top with value ~0 (so to depict the true meaning of "any"), or is it intentional to confine the OS set?
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Cleanup PlatformID and PlatformDetection usage Commit migrated from dotnet/corefx@131b26f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily a search-and-replace change. Two parts:
[ActiveIssue(..., PlatformID.Linux | PlatformID.OSX)]with[ActiveIssue(..., PlatformID.AnyUnix)]. This will make it easier to add new Unix platforms and have most of the affected tests automatically disabled.Interop.PlatformDetection.OperatingSystem == Interop.OperatingSystem.WindowswithInterop.IsWindows.