This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Merge changes from TFS #1754
Merged
Merge changes from TFS #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
48 of the 66 XmlSerializer tests are failing with this change, due to NotSupportedExceptions being thrown. |
|
Please don't merge this as is, I would also like to fix up the commit messages as well. |
[tfs-changeset: 1471040]
Certain serialization exception messages ask users to "Consult the SDK documentation...". This change adds an FWLink directly to the rd.xml documentation. [tfs-changeset: 1471256]
|
Messages updated, I will try to look at the failures in a little bit. |
|
@ellismg @weshaggard are either of you looking at this? Can we just disable these tests and file an issue to unblock the mirror? I have a huge change that needs to mirror soon otherwise we'll start getting mere issues. |
|
I will just disable the tests and file an issue, I agree getting things unblocked is good. |
The recent merge of changes from TFS is causing a bunch of these XmlSerializer tests to fail. In order to continue flowing code between Git and TFS, we are just disabling these tests and will investigate the failures after checking in.
|
//cc @khdang I'm guessing this was caused by the consolidation with NETNative implementation. I spent some time digging through the diff and couldn't find the bug. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Merge changes from TFS Commit migrated from dotnet/corefx@967ab1c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.