Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Add FreeBSD support to System.Console. #2031

Merged
merged 1 commit into from
Jun 13, 2015

Conversation

janhenke
Copy link
Member

This commit adds the necessary Interop pieces necessary for System.Console. Also add FreeBSD to the System.Console project.

This commit adds the necessary Interop pieces necessary for System.Console. Also add FreeBSD to the System.Console project.
@Maxwe11
Copy link
Contributor

Maxwe11 commented Jun 13, 2015

Add FreeBSD support to System.Console

Sounds like implementation but this just pieces of interops 😄
Why this should get in repo before implementation?

@janhenke
Copy link
Member Author

FreeBSD is a Unix system. There is already a Unix implementation. If you take a look into the files, the Interops are actually the only thing being different between Linux/OS X (and FreeBSD).

@Maxwe11
Copy link
Contributor

Maxwe11 commented Jun 13, 2015

@janhenke 👍 yeah but I'm confused with that src/Common/src/Interop/FreeBSD/Interop.Libraries.cs not included in csproj

@janhenke
Copy link
Member Author

That one file is not used by System.Console. It is actually identical to the Linux Interop file with the same name. Since the content is trivial, I added it as well. I assume some other assembly will need it.

@stephentoub
Copy link
Member

I didn't check the values used, but the mechanics of the change LGTM. Nice job plugging this in.

stephentoub added a commit that referenced this pull request Jun 13, 2015
Add FreeBSD support to System.Console.
@stephentoub stephentoub merged commit bb55909 into dotnet:master Jun 13, 2015
@josteink
Copy link
Member

I agree with @janhenke on this one.

While Libraries isn't used right now, it logically belongs with the rest of those files and it makes sense to introduce them all in the same commit. It will probably come to use sooner rather than later.

LGTM

@janhenke janhenke deleted the freebsd-system.console branch June 13, 2015 11:31
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…nsole

Add FreeBSD support to System.Console.

Commit migrated from dotnet/corefx@bb55909
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants