Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively (master) #25872

dotnet-maestro-bot · 2017-12-12T22:29:14Z

No description provided.

pakrym · 2017-12-13T00:24:44Z

@ahsonkhan any idea when this would go in? We are blocked on fix for https://github.com/dotnet/coreclr/issues/15432

dotnet-maestro-bot · 2017-12-13T01:36:36Z

Discarded 35f7112 (9:x: 4:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26011-03, preview1-26012-03, preview1-26012-06, beta-26012-00, beta-26012-00, respectively

❌ Linux arm Release Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
❌ Packaging All Configurations x64 Debug Build Build finished. Details
❌ Tizen armel Debug Build Build finished. Details
❌ UWP CoreCLR x64 Debug Build Build finished. Details
❌ UWP NETNative x86 Release Build Build finished. Details
❌ Windows x64 Debug Build Build finished. Details
❌ Windows x86 Release Build Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ NETFX x86 Release Build Build finished. Details
✔️ WIP ready for review Details

ahsonkhan · 2017-12-13T01:43:33Z

any idea when this would go in? We are blocked on fix for https://github.com/dotnet/coreclr/issues/15432

See previous update which got blocked on some other test failures -
#25821 (comment)

@swgillespie, any progress on the issue that resulted in System.Net.Sockets tests to fail?

swgillespie · 2017-12-13T02:55:15Z

@ahsonkhan I have been looking at this issue but I have still been unable to find the root cause. Should I revert the PR to unblock this?

@pakrym Reverting that PR will also fix your issue, since it's the same PR that introduced the bug in the first place.

ahsonkhan · 2017-12-13T02:58:31Z

I have been looking at this issue but I have still been unable to find the root cause. Should I revert the PR to unblock this?

How long do you expect it would take? Imo, I would revert the PR to unblock this if you won't be able to resolve it by eod, especially since I also have dependencies upcoming that would require clean updates from coreclr/ProjectN.

swgillespie · 2017-12-13T03:02:07Z

@ahsonkhan In that case I will revert it. I still don't understand the root cause and I don't have a ETA.

ahsonkhan · 2017-12-13T03:06:56Z

In that case I will revert it.

Great. Tyvm. Please cc me on your PR so I know when to expect an update of coreclr (and then I can cherry-pick my changes from #25770).

benaadams · 2017-12-13T03:09:08Z

In that case I will revert it.

Might be easiest; coreclr and corefx are currently out of sync due to the api change

error : MembersMustExist : Member 'System.Buffers.OwnedMemory<T>.Pin()' 
  does not exist in the implementation but it does exist in the contract.

So its currently hard to test them together. When they are back in sync then you can run the tests:

@dotnet-bot test Windows_NT x64 Checked corefx_baseline
@dotnet-bot test Ubuntu x64 Checked corefx_baseline

in coreclr which should help track down the bug and/or determine if its fixed?

swgillespie · 2017-12-13T03:15:46Z

@benaadams great, thanks! i'm not used to GC issues leaking into corefx... unfortunately the PR in question here touches async pinned handles and I guess the CoreCLR test suite doesn't do much I/O.

benaadams · 2017-12-13T03:19:32Z

They are good verifying tests as they pull in current corefx and run with the PRs coreclr; for example I'm using them to verify changes to Dictionary dotnet/coreclr#15460 (comment) as its a bit far ranging to just do the Collection tests locally from corefx on my single platform

swgillespie · 2017-12-13T03:42:02Z

dotnet/coreclr#15498

dotnet-maestro-bot · 2017-12-13T04:01:20Z

Discarded 51ead33 (10:x: 4:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-01, preview1-26012-03, preview1-26012-06, beta-26012-00, beta-26012-00, respectively

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Linux arm Release Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
❌ Packaging All Configurations x64 Debug Build Build finished. Details
❌ Tizen armel Debug Build Build finished. Details
❌ UWP CoreCLR x64 Debug Build Build finished. Details
❌ UWP NETNative x86 Release Build Build finished. Details
❌ Windows x64 Debug Build Build finished. Details
❌ Windows x86 Release Build Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ NETFX x86 Release Build Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2017-12-13T06:08:19Z

Discarded 20b833d (10:x: 4:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-01, preview1-26013-03, preview1-26012-06, beta-26012-00, beta-26012-00, respectively

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Linux arm Release Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
❌ Packaging All Configurations x64 Debug Build Build finished. Details
❌ Tizen armel Debug Build Build finished. Details
❌ UWP CoreCLR x64 Debug Build Build finished. Details
❌ UWP NETNative x86 Release Build Build finished. Details
❌ Windows x64 Debug Build Build finished. Details
❌ Windows x86 Release Build Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ NETFX x86 Release Build Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2017-12-13T06:14:40Z

Discarded 1f19144 (1:x: 10:hourglass: 3:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-01, preview1-26013-04, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

❌ OSX x64 Debug Build Build finished. Details
⌛ Alpine.3.6 x64 Debug Build Started Details
⌛ Linux arm Release Build Started. Details
⌛ Linux x64 Release Build Started Details
⌛ NETFX x86 Release Build Started Details
⌛ Packaging All Configurations x64 Debug Build Started Details
⌛ Tizen armel Debug Build Triggered. (1/4 on ubuntu1404-20170120)
⌛ UWP CoreCLR x64 Debug Build Started Details
⌛ UWP NETNative x86 Release Build Started Details
⌛ Windows x64 Debug Build Started Details
⌛ Windows x86 Release Build Started Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2017-12-13T06:36:11Z

Discarded e5bdd62 (3:x: 8:hourglass: 3:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-01, preview1-26013-04, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
⌛ Linux arm Release Build Triggered. (2/4 on ubuntu1404-20170120)
⌛ NETFX x86 Release Build Started Details
⌛ Packaging All Configurations x64 Debug Build Started Details
⌛ Tizen armel Debug Build Triggered. (3/4 on ubuntu1404-20170120)
⌛ UWP CoreCLR x64 Debug Build Started Details
⌛ UWP NETNative x86 Release Build Started Details
⌛ Windows x64 Debug Build Started Details
⌛ Windows x86 Release Build Started Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2017-12-13T13:28:50Z

Discarded 3378c4e (10:x: 4:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-02, preview1-26013-04, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Linux arm Release Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
❌ Packaging All Configurations x64 Debug Build Build finished. Details
❌ Tizen armel Debug Build Build finished. Details
❌ UWP CoreCLR x64 Debug Build Build finished. Details
❌ UWP NETNative x86 Release Build Build finished. Details
❌ Windows x64 Debug Build Build finished. Details
❌ Windows x86 Release Build Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ NETFX x86 Release Build Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2017-12-13T14:41:49Z

Discarded 5543f18 (10:x: 4:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-04, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Linux arm Release Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
❌ Packaging All Configurations x64 Debug Build Build finished. Details
❌ Tizen armel Debug Build Build finished. Details
❌ UWP CoreCLR x64 Debug Build Build finished. Details
❌ UWP NETNative x86 Release Build Build finished. Details
❌ Windows x64 Debug Build Build finished. Details
❌ Windows x86 Release Build Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ NETFX x86 Release Build Build finished. Details
✔️ WIP ready for review Details

dotnet-maestro-bot · 2017-12-13T17:50:36Z

Discarded fd0ff4d (10:x: 4:heavy_check_mark:) Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-05, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

❌ Alpine.3.6 x64 Debug Build Build finished. Details
❌ Linux arm Release Build Build finished. Details
❌ Linux x64 Release Build Build finished. Details
❌ OSX x64 Debug Build Build finished. Details
❌ Packaging All Configurations x64 Debug Build Build finished. Details
❌ Tizen armel Debug Build Build finished. Details
❌ UWP CoreCLR x64 Debug Build Build finished. Details
❌ UWP NETNative x86 Release Build Build finished. Details
❌ Windows x64 Debug Build Build finished. Details
❌ Windows x86 Release Build Build finished. Details
✔️ CROSS Check Build finished. Details
✔️ license/cla All CLA requirements met. Details
✔️ NETFX x86 Release Build Build finished. Details
✔️ WIP ready for review Details

…fsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

mmitche · 2017-12-13T19:13:06Z

The ApiCompat error is currently blocking the ProdCon build. Is there a plan to resolve this issue?

/fyi @dleeapho @jaredpar @weshaggard

ahsonkhan · 2017-12-13T19:23:24Z

Cherry-picked the commits from #25770

benaadams · 2017-12-13T20:22:16Z

System.Net.Sockets.Tests and System.Net.Http.Functional.Tests failing; look like same errors as before? #25821 (comment)

 Unhandled Exception: System.InvalidOperationException: 'overlapped' has already been freed.
    at System.Threading.ThreadPoolBoundHandleOverlapped.CompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped) in E:\A\_work\1993\s\src\mscorlib\src\System\Threading\ClrThreadPoolBoundHandleOverlapped.cs:line 47
    at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP) in E:\A\_work\1993\s\src\mscorlib\src\System\Threading\Overlapped.cs:line 101
    System.Net.Sockets.Tests.SendReceiveMemoryNativeTask.Receive0ByteReturns_WhenPeerDisconnects [FAIL]
       Task should not have been completed, was Faulted
       Expected: False
       Actual:   True
       Stack Trace:
          D:\j\workspace\windows-TGrou---f8ac6754\src\System.Net.Sockets\tests\FunctionalTests\SendReceive.cs(699,0): at System.Net.Sockets.Tests.SendReceive`1.<Receive0ByteReturns_WhenPeerDisconnects>d__9.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
          --- End of stack trace from previous location where exception was thrown ---
          --- End of stack trace from previous location where exception was thrown ---
 
 Unhandled Exception: System.InvalidOperationException: 'overlapped' has already been freed.
    at System.Threading.ThreadPoolBoundHandleOverlapped.CompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped) in E:\A\_work\1993\s\src\mscorlib\src\System\Threading\ClrThreadPoolBoundHandleOverlapped.cs:line 47
    at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP) in E:\A\_work\1993\s\src\mscorlib\src\System\Threading\Overlapped.cs:line 101
    System.Net.Sockets.Tests.SendReceiveMemoryNativeTask.SendRecv_0ByteReceive_Success [FAIL]
       Assert.False() Failure
       Expected: False
       Actual:   True
       Stack Trace:
          D:\j\workspace\windows-TGrou---f8ac6754\src\System.Net.Sockets\tests\FunctionalTests\SendReceive.cs(658,0): at System.Net.Sockets.Tests.SendReceive`1.<SendRecv_0ByteReceive_Success>d__8.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
          --- End of stack trace from previous location where exception was thrown ---
          --- End of stack trace from previous location where exception was thrown ---
 Finished running tests.  End time=20:01:43.45, Exit code = -532462766

dotnet-maestro-bot · 2017-12-13T21:58:23Z

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-10, preview1-26013-04, beta-26013-00, beta-26013-00, respectively'

ahsonkhan · 2017-12-13T22:23:58Z

cc @swgillespie, @jkotas, any ideas?

ahsonkhan · 2017-12-13T22:31:12Z

@dotnet-bot test Linux x64 Release Build

weshaggard · 2017-12-13T22:39:05Z

Looks like preview1-26013-03 version of coreclr doesn't contain @swgillespie's revert change dotnet/coreclr#15498. So there must be something else causing these failures.

dotnet-maestro-bot · 2017-12-13T23:46:04Z

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-11, preview1-26013-05, beta-26013-00, beta-26013-00, respectively'

dotnet-maestro-bot · 2017-12-14T01:25:57Z

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26014-01, preview1-26013-12, preview1-26013-05, beta-26013-00, beta-26013-00, respectively'

ahsonkhan · 2017-12-14T01:29:51Z

Closing this PR so a new one can get generated.

We still have Windows specific test failures.

jkotas · 2017-12-14T03:30:38Z

@ahsonkhan The Windows specific socket failures are caused by your Pin() changes. I am going to revert the change in CoreCLR to get things unstuck.

ahsonkhan · 2017-12-14T03:33:58Z

This change - dotnet/coreclr#15410?

pakrym mentioned this pull request Dec 13, 2017

Update runtime corefxlab and corefx lab packages when GC and API changes would go through aspnet/Universe#710

Closed

joshfree assigned ahsonkhan Dec 13, 2017

joshfree added this to the 2.1.0 milestone Dec 13, 2017

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 35f7112 to 51ead33 Compare December 13, 2017 01:36

swgillespie mentioned this pull request Dec 13, 2017

Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)" dotnet/coreclr#15498

Merged

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 51ead33 to 20b833d Compare December 13, 2017 04:01

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 20b833d to 1f19144 Compare December 13, 2017 06:08

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 1f19144 to e5bdd62 Compare December 13, 2017 06:14

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from e5bdd62 to 3378c4e Compare December 13, 2017 06:36

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 3378c4e to 5543f18 Compare December 13, 2017 13:29

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 5543f18 to fd0ff4d Compare December 13, 2017 14:42

Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNT…

c73acae

…fsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from fd0ff4d to c73acae Compare December 13, 2017 17:50

ahsonkhan added 4 commits December 13, 2017 11:22

Change Pin to take an optional integer offset.

8d54c47

Add optional offset to Pin in System.Runtime ref.

1db2d8b

Add bounds checks for offset in classes that impl OwnedMemory

19dc774

Adding compiler services using directive to use Unsafe.

687a93a

ahsonkhan closed this Dec 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively (master) #25872

Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively (master) #25872

dotnet-maestro-bot commented Dec 12, 2017 •

edited

Loading

pakrym commented Dec 13, 2017 •

edited by ahsonkhan

Loading

dotnet-maestro-bot commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

swgillespie commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

swgillespie commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

benaadams commented Dec 13, 2017

swgillespie commented Dec 13, 2017

benaadams commented Dec 13, 2017

swgillespie commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

mmitche commented Dec 13, 2017 •

edited

Loading

ahsonkhan commented Dec 13, 2017

benaadams commented Dec 13, 2017 •

edited

Loading

dotnet-maestro-bot commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

weshaggard commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 14, 2017

ahsonkhan commented Dec 14, 2017

jkotas commented Dec 14, 2017

ahsonkhan commented Dec 14, 2017

Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively (master) #25872

Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02312-02, preview1-26013-03, preview1-26013-06, preview1-26012-06, beta-26013-00, beta-26013-00, respectively (master) #25872

Conversation

dotnet-maestro-bot commented Dec 12, 2017 • edited Loading

pakrym commented Dec 13, 2017 • edited by ahsonkhan Loading

dotnet-maestro-bot commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

swgillespie commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

swgillespie commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

benaadams commented Dec 13, 2017

swgillespie commented Dec 13, 2017

benaadams commented Dec 13, 2017

swgillespie commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

mmitche commented Dec 13, 2017 • edited Loading

ahsonkhan commented Dec 13, 2017

benaadams commented Dec 13, 2017 • edited Loading

dotnet-maestro-bot commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

ahsonkhan commented Dec 13, 2017

weshaggard commented Dec 13, 2017

dotnet-maestro-bot commented Dec 13, 2017

dotnet-maestro-bot commented Dec 14, 2017

ahsonkhan commented Dec 14, 2017

jkotas commented Dec 14, 2017

ahsonkhan commented Dec 14, 2017

dotnet-maestro-bot commented Dec 12, 2017 •

edited

Loading

pakrym commented Dec 13, 2017 •

edited by ahsonkhan

Loading

mmitche commented Dec 13, 2017 •

edited

Loading

benaadams commented Dec 13, 2017 •

edited

Loading