Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fixed ReadAsync blocking issue #26595

Merged
merged 5 commits into from
Jan 31, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2499,9 +2499,6 @@ private bool TryProcessDone(SqlCommand cmd, SqlDataReader reader, ref RunBehavio
ushort status;
int count;

// Can't retry TryProcessDone
stateObj._syncOverAsync = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change specifically? Framework TdsParser also has this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment // Can't retry TryProcessDone seems interesting. Looks like syncOverAsync was set to true to prevent a retry of processing the Done TDS token. Have you checked if this "retry" is not invoked after your changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corivera TryProcessDone sets syncOverAsync during async execution which makes the execution sync for pretty much everything, since syncOverAsync forces a blocking network call. TryProcessDone was turning out to be a bottleneck that @geleems figured out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and TryProcessDone() was not retried after my change. However, I have just become curious what happens if I force it to retry TryProcessDone() by following code:

I meant , are there code paths which could retry Done token processing in certain scenarios for a single SqlDataReader Read operation, instead of multiple Read() operations, which needs to be prevented?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabh500
TryProcessDone() runs multiple times until ReadSni() actually returns packets, and it is processed by TryProcessDone(). Once DONE token is processed, codeflow moves forward, and there is no code path to RETRY the DONE token processing, which is already done.


// status
// command
// rowcount (valid only if DONE_COUNT bit is set)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Diagnostics;
using System.Threading.Tasks;
using Xunit;

Expand All @@ -11,7 +12,7 @@ public static class AsyncTest
{
private const int TaskTimeout = 5000;

[CheckConnStrSetupFact]
//[CheckConnStrSetupFact]
public static void ExecuteTest()
{
SqlCommand com = new SqlCommand("select * from Orders");
Expand All @@ -36,7 +37,7 @@ public static void ExecuteTest()
con.Close();
}

[CheckConnStrSetupFact]
//[CheckConnStrSetupFact]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to clean this method and the one above. Looks like they are not used and the [Fact] attribute has been removed

public static void FailureTest()
{
bool failure = false;
Expand Down Expand Up @@ -91,5 +92,99 @@ public static void FailureTest()
readerTask.Result.Dispose();
con.Close();
}


[CheckConnStrSetupFact]
public static void TestReadAsync()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be changed to TestReadAsyncTimeConsumed

{
CompareReadSyncAndReadAsync();
}

private static async void CompareReadSyncAndReadAsync()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method doesn't need to be async

{
const string sql = "SET NOCOUNT ON"
+ " SELECT 'a'"
+ " DECLARE @t DATETIME = SYSDATETIME()"
+ " WHILE DATEDIFF(s, @t, SYSDATETIME()) < 20 BEGIN"
+ " SELECT 2 x INTO #y"
+ " DROP TABLE #y"
+ " END"
+ " SELECT 'b'";
double elapsedAsync = await RunReadAsync(sql);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to wait on the task returned by RunReadAsync(sql);

double elapsedSync = RunReadSync(sql);
Assert.True(elapsedAsync < (elapsedSync / 2.0d));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to improve this assert in future commits?

}

private static async Task<double> RunReadAsync(string sql)
{
double maxElapsedTimeMillisecond = 0;
using (SqlConnection connection = new SqlConnection(DataTestUtility.TcpConnStr))
{
await connection.OpenAsync();
using (SqlCommand command = connection.CreateCommand())
{
command.CommandText = sql;
using (SqlDataReader reader = await command.ExecuteReaderAsync())
{
Task<bool> t;
Stopwatch stopwatch = new Stopwatch();
do
{
do
{
stopwatch.Start();
t = reader.ReadAsync();
stopwatch.Stop();
double elased = stopwatch.Elapsed.TotalMilliseconds;
if (maxElapsedTimeMillisecond < elased)
{
maxElapsedTimeMillisecond = elased;
}
}
while (await t);
}
while (reader.NextResult());
}
}
}

return maxElapsedTimeMillisecond;
}

private static double RunReadSync(string sql)
{
double maxElapsedTimeMillisecond = 0;
using (SqlConnection connection = new SqlConnection(DataTestUtility.TcpConnStr))
{
connection.Open();
using (SqlCommand command = connection.CreateCommand())
{
command.CommandText = sql;
using (SqlDataReader reader = command.ExecuteReader())
{
bool result;
Stopwatch stopwatch = new Stopwatch();
do
{
do
{
stopwatch.Start();
result = reader.Read();
stopwatch.Stop();
double elased = stopwatch.Elapsed.TotalMilliseconds;
if (maxElapsedTimeMillisecond < elased)
{
maxElapsedTimeMillisecond = elased;
}
}
while (result);
}
while (reader.NextResult());
}
}
}

return maxElapsedTimeMillisecond;
}
}
}