This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SqlClient: Avoid a delegate allocation on each call #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ static Locale() | |||
| { | |||
| throw ADP.ArgumentOutOfRange("lcid"); | |||
| } | |||
| return s_cachedEncodings.GetOrAdd(lcid, GetDetailsInternal); | |||
| return s_cachedEncodings.GetOrAdd(lcid, id => GetDetailsInternal(id)); | |||
There was a problem hiding this comment.
Put a comment here to nobody "fixes it". TBH, the compiler should just fix this bug. @stephentoub reported it like 2 years ago...
/cc @jaredpar
There was a problem hiding this comment.
See: dotnet/roslyn#5835
There was a problem hiding this comment.
A bug is when the compiler behaves counter to the design. The compiler is behaving as designed here so not a bug.
|
LGTM cc: @saurabh500 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
SqlClient: Avoid a delegate allocation on each call Commit migrated from dotnet/corefx@5184919
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the compiler to lazily allocate and cache the
Funcdelegate instead of allocating a new delegate on each call toGetDetailsForLcid.