This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 508
Finalize story for reflection roots #5001
Comments
tonerdo
added a commit
to tonerdo/corert
that referenced
this issue
Nov 21, 2018
tonerdo
added a commit
to tonerdo/corert
that referenced
this issue
Nov 24, 2018
jkotas
pushed a commit
that referenced
this issue
Dec 17, 2018
* add support for stloc, ldloc, pop and dup (#5011) * add support for not and neg opcodes (#5011) * add preliminary support for conv.* opcodes (#5011) * add preliminary support for comparison opcodes (#5011) * rename StackItem *IntPtr methods to *NativeInt (#5011) * add preliminary support for conversion opcodes (#5011) * add implementation for bitwise shift opcodes (#5001) * use checked blocks for overflow conversions (#5011) * make improvements to interpreter code (#5011) * use IsVoid to check for voidness of method return type (#5011) * switch to switch statements where possible (#5011) * add unchecked variant of StackItem As* methods (#5011) * some code enhancements * ensure correct behaviour for signed and unsigned numbers (#5011) * specifically check for unsigned comparison opcodes (#5011)
Also the error message CoreRT emits will lead you down the wrong path.
The link will then feed you with <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
<Application>
<Type Name="System.GC">
<MethodInstantiation Name="AllocateArray" Arguments="System.Byte" Dynamic="Required" />
</Type>
</Application>
</Directives> which then causes this helpful message to popup during build
which is because it only ever expects Managed to reverse engineer the correct incarnation <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
<Application>
<Assembly Name="System.Private.CoreLib">
<Type Name="System.GC" Dynamic="Required All">
<Method Name="AllocateArray" Dynamic="Required All">
<GenericArgument Name="System.Byte" />
</Method>
</Type>
</Assembly>
</Application>
</Directives> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The compiler currently supports a weird dialect of RD.XML (it's far from a proper subset) to describe dynamic behavior of the app. Placing full RD.XML support into the compiler is not feasible (as it requires whole program analysis).
We should explore:
The text was updated successfully, but these errors were encountered: