This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Add RuntimeHelpers.IsReferenceOrContainsReferences<T>() #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work towards dotnet/corefx#14047
jkotas
commented
Feb 12, 2017
| TypeDesc elementType = method.Instantiation[0]; | ||
|
|
||
| // Fallback to non-intrinsic implementation for universal generics | ||
| if (elementType.IsCanonicalSubtype(CanonicalFormKind.Universal)) |
There was a problem hiding this comment.
@MichalStrehovsky Is this the right condition to use here?
|
I am also going to open bug to add the matching expansion in NUTC once it goes in. |
MichalStrehovsky
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for Span and work towards dotnet/corefx#14047