Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec partial properties behavior with doc comments #8131

Merged
merged 2 commits into from
May 16, 2024
Merged

Spec partial properties behavior with doc comments #8131

merged 2 commits into from
May 16, 2024

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson requested a review from a team as a code owner May 15, 2024 23:34
jcouv
jcouv approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@RikkiGibson RikkiGibson merged commit da1a2a7 into main May 16, 2024
1 check passed
@RikkiGibson RikkiGibson deleted the partial-properties-doc-comments branch May 16, 2024 23:43
@RikkiGibson RikkiGibson mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RikkiGibson @333fred @jcouv